Fix memory when reuse reordering is used with matrices with different nonzero patterns.

Reported-by: Markus Breit

Crash when using MUMPs sequentially with -pc_factor_nonzeros_along_diagonal but using MUMPS ordering.

$ PETSC_OPTIONS="-pc_factor_mat_ordering_type external" python pythonprogram.py
[0]PETSC ERROR:

Crash when using MUMPs sequentially with -pc_factor_nonzeros_along_diagonal but using MUMPS ordering.

$ PETSC_OPTIONS="-pc_factor_mat_ordering_type external" python pythonprogram.py
[0]PETSC ERROR: ------------------------------------------------------------------------
[0]PETSC ERROR: Caught signal number 11 SEGV: Segmentation Violation, probably memory access out of range
[0]PETSC ERROR: Try option -start_in_debugger or -on_error_attach_debugger
[0]PETSC ERROR: or see https://petsc.org/release/faq/#valgrind and https://petsc.org/release/faq/
[0]PETSC ERROR: --------------------- Stack Frames ------------------------------------
The line numbers in the error traceback are not always exact.
[0] #1 MatReorderForNonzeroDiagonal_SeqAIJ() at /Users/barrysmith/Src/petsc/src/mat/utils/zerodiag.c:77
[0] #2 MatReorderForNonzeroDiagonal() at /Users/barrysmith/Src/petsc/src/mat/utils/zerodiag.c:61
[0] #3 PCSetUp_LU() at /Users/barrysmith/Src/petsc/src/ksp/pc/impls/factor/lu/lu.c:84
[0] #4 PCSetUp() at /Users/barrysmith/Src/petsc/src/ksp/pc/interface/precon.c:1120
[0] #5 KSPSetUp() at /Users/barrysmith/Src/petsc/src/ksp/ksp/interface/itfunc.c:429

Bug was it still tried the nonzero diagonal reordering even when the ordering type was external so PETSc did not generate an ordering

Also fixed bug in PCSetUp_Cholesky() where it used GetBool on -pc_factor_nonzeros_along_diagonal when the argument may be followed by a numerical value

Reported-by: Jørgen Dokken

show more ...

PC: add PCMatApplyTranspose()

Fortran 90: fully embrace After 34 years!

- deprecate use of 'F90' in Fortran function names
- use Fortran pointers when appropriate
- the new Fortran API is not backward compatible with previous ve

Fortran 90: fully embrace After 34 years!

- deprecate use of 'F90' in Fortran function names
- use Fortran pointers when appropriate
- the new Fortran API is not backward compatible with previous versions!
- also clean up inconsistent PETSc code detected by new Fortran generation tools
- drop use of bfort
- automatically generate all the Fortran PETSc objects, enums etc from the include files
- generate most of the Fortran interface definitions and functions from the source code
- simplify the number and organization of Fortran modules

Co-authored-by: Jose E. Roman <jroman@dsic.upv.es>

show more ...