checkbadSource: enforce proper style in makefiles

distinguish Boolean and Integer

MPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Name
this flag "iflg" (was used somewhere already).
Use MPI_LAND instead of MPI_BAND for logical op

distinguish Boolean and Integer

MPI_Comm_get_attr has PetscMPIInt as flag argument, not PetscBool. Name
this flag "iflg" (was used somewhere already).
Use MPI_LAND instead of MPI_BAND for logical operations instead of
MPI_MIN, MPI_MAX, and MPI_LAND.

Note: Most of the previous code was probably working as intended, I did
the changes when debugging error related to the use of standard C Bool and
kept them because it took me a while to understand that MPI has integer
flags and PETSc has Booleans. Using different names makes this clear,
but was and is not done consistently.

show more ...

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat

One-liners from petsc/petsc!5344 and petsc/petsc!5557

Slightly reworked regular expression

git ls-files -z -- '*.c' '*.cxx' '*.cu' '*.h' '*.hpp' '*.cpp' | while IFS= read -r -d '' file; do
cat $file | tr '\n' '\r' | sed -E 's/\r([ ]*)(for|if|while|else) ([^\r]*)\{\r[ ]*Petsc([a-zA-Z]*)\(([^\r]*)\);\r[ ]*\}\r/\r\1\2 \3Petsc\4(\5);\r/g' | tr '\r' '\n' > ${file}.joe; mv ${file}.joe ${file}
done

show more ...