Fortran is always F2003: removed leftovers
place all the include statements at the topRepeated inclusion in multiple location, e.g. at the start of amodule or function is not needed. This becomes clear if all includes areoutside of the ac
place all the include statements at the topRepeated inclusion in multiple location, e.g. at the start of amodule or function is not needed. This becomes clear if all includes areoutside of the actual Fortran code.Added regex to check that with the help of @sbalay
show more ...
checkbadSource: enforce proper style in makefiles
Run fprettify
Remove explicitly listed empty files and switch to output/empty.out
fortran no semicolon at end of lineRemove all unneeded ; at end of Fortran source code lineAdd checkbadSource to check for semicolon at the end of lines
Plex+HDF5: Fix compression handling in HDF5 output- Add compress flag to HDF5 Viewer- Add PetscViewerHDF5SetCompress() and PetscViewerHDF5GetCompress()- Initialize IS compressOutput to PETSC_TRUE
Plex+HDF5: Fix compression handling in HDF5 output- Add compress flag to HDF5 Viewer- Add PetscViewerHDF5SetCompress() and PetscViewerHDF5GetCompress()- Initialize IS compressOutput to PETSC_TRUE and check viewer flag as well- Turn on viewer compression rather than flip IS flag in Plex output
Use NULL or nullptr instead of casted 0
Fix fortran tests not compiling with CRAY compilers
Add shared memory support for PCMPI using both shmget() and MPI_Win_allocate_shared()
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VI
The use case of PetscOptionsGetViewer() has evolved to no longer be the get/restore modelHence the code needs to be refactoredIntroduce PetscCallNull() and PetscCallMPINull() to simplify PETSC_VIEWER_XXXX_() routinesReported-by: James WrightThanks-to: Jeremy L Thompson
Update to sowing version that supports PetscViewer and PetscObjectRemove manual Fortran stubs for PetscViewer and PetscObject arguments since now handled by sowingAlso handles the passing of null
Update to sowing version that supports PetscViewer and PetscObjectRemove manual Fortran stubs for PetscViewer and PetscObject arguments since now handled by sowingAlso handles the passing of null objects correctly
Fix "Extra spaces in test harness rules" in checkbadSource
Remove MANSEC from makefiles it is not needed in, tutorials and tests
Fix PetscOptionsGetViewer() so it works in a thread-safe wayWhen PetscOptionsGetViewer() returns, for example, PETSC_VIEWER_STDOUT_SELF the same object is sharedby all threads that call PetscOptio
Fix PetscOptionsGetViewer() so it works in a thread-safe wayWhen PetscOptionsGetViewer() returns, for example, PETSC_VIEWER_STDOUT_SELF the same object is sharedby all threads that call PetscOptionsGetViewer(). In the previous code PetscObjectReference() anddereference (via PetscViewerDestroy() where called on the viewer by multiple threads after the viewerwas accessed thus corrupting the object.This branch introduces a PetscOptionsRestoreViewer() that allows not doing the referencing and dereferencingon persistant viewers, thus removing the specific race condition above.Other possible solutions includeUse a lock on each PetscObjectReference/Dereference() just in case they are shared. Could be time consuming so onecould mark each object as either threadshared or independent and only do the locks on threadshared objects. This lowersthe cost but would require more extensive changes to PETSc infrastructure. And I do not know if this shared/not shared modelis what we need in the long run, though it might be.
Remove first and last empty lines
Add PetscCheck() and PetscCheckA() for FortranAlso fix incorrect use of " in Fortran examples that should be '
Remove need for seperate lib/petsc/conf/test file by merging with rules fileCommit-type: maintainability
Remove unneeded declarations of LOCDIR from all the makefilesCommit-type:documentation
source code format changes due to .clang-format changes
docs: remove SUBMANSEC from example makefiles - and use only MANSEC (it tells what library the tests need)
Remove braces from one-liners
clang-format: convert PETSc sources to comply with clang-format
Add PetscFunctionBeginUser to all PETSc C/C++ examplesNow the stack frames will contain the main program and the correct line numbers in themgit ls-files | egrep "(tutorials|tests)" | xargs sed -
Add PetscFunctionBeginUser to all PETSc C/C++ examplesNow the stack frames will contain the main program and the correct line numbers in themgit ls-files | egrep "(tutorials|tests)" | xargs sed -i "s?\(PetscCall(PetscInitialize(&argc\)?PetscFunctionBeginUser;\n \1?g"Commit-type: error-checking, testing-fix/spend 15m
Add modern error checking to rest of Fortran examples/spend 2.5h
12