add typedef for functions passed to SNESSetFunction() etc to match approach in TSI never liked Jed's use of typedef for function prototypes for a couple of reasons1) you don't see immediately tha
add typedef for functions passed to SNESSetFunction() etc to match approach in TSI never liked Jed's use of typedef for function prototypes for a couple of reasons1) you don't see immediately that the argument to the function is a function pointer instead of standard variable when looking at source2) you don't see at the exact location in the code the prototype of the function being passed inbut there is something to say for using these typedefs soI've prototyped the change for SNES but slightly differently than what Jed did for TS1) I append the typedef with _Ftn to mark that it is a function (helping to relieve the problem 1 above)2) I made the typedef to be for a function, not a function pointer so it can also be used directly for things likePETSC_EXTERN SNESJacobian_Ftn SNESComputeJacobianDefault;I think the TS usage could be switched to this style without user code breakage, and deprecate the current TS typedefThoughts?Just do SNES the same way as TS and live with less clarity?
show more ...
LIBBASE is no longer used in make so remove it
Merge remote-tracking branch 'origin/release'
Update references in the manual pages to use Sphinx citation processing
SNESLINESEARCHBT: fix quadratic interpolation caseimprove code readiblity
Fix some manual pages focusing on SNES
Merge branch 'barry/2023-10-25/rename-rules-doc' into 'main'Rename rules.doc and rules.utils because GitLab treats the former as a MS Word document.See merge request petsc/petsc!6965
Merge branch 'stefanozampini/ngmres-objective' into 'main'Support objective functions in SNESNGMRESSee merge request petsc/petsc!6957
SNESLinesearch: align all linesearches to the behaviour of BTupdate docs
Rename rules.doc and rules.utils because GitLab treats the former as a MS Word document.Thanks-to: Jed Brown
Remove DIRS variable and unneeded tabs from all makefiles since no longer neededCommit-type: housekeeping
Fix some malformed if !defined() header guards
Add static to internal functions
Fix missing new lines at the end of PetscInfo() calls
Manual linter fixes: snes
... and apply it
Rename PetscValidPointer -> PetscAssertPointer
Lint apply: snes
HAVE_FORTRAN should be USE_FORTRAN_BINDINGS since it is about generating the Fortran bindings, not about if the Fortran compiler exists
Merge branch 'barry/2023-04-10/fix-linesearch-maxstep/release' into 'release'Minor comment, manual page cleanup for snes linesearchSee merge request petsc/petsc!6308
Minor comment, manual page cleanup for snes linesearchBranch-name: barry/2023-04-10/fix-linesearch-maxstep/releaseBranch-root: releaseBranch-purpose: Fix bug in handling of -snes_linesearch_maxst
Minor comment, manual page cleanup for snes linesearchBranch-name: barry/2023-04-10/fix-linesearch-maxstep/releaseBranch-root: releaseBranch-purpose: Fix bug in handling of -snes_linesearch_maxstep that should make it a relative, not absolute value
Format the ftn-custom files with clang-format. Apparently no particular reason we did not format them initially
non-test and tutorial makefiles only need rules.doc not the full rulesCommit-type: documentation
123456789