checkbadSource: enforce proper style in makefiles
Use NULL or nullptr instead of casted 0
Deprecate PETSC_DEFAULT for Tao parameters with PETSC_CURRENT and add support for PETSC_DETEREMINE to use default
Some Tao monitor options are incorrectly called viewers, yikes and more yikesCorrect ``-tao_view_gradient``, ``-tao_view_ls_residual``, ``-tao_view_solution``, and ``-tao_view_stepdirection`
Fix "Extra spaces in test harness rules" in checkbadSource
Remove MANSEC from makefiles it is not needed in, tutorials and tests
Remove DIRS variable and unneeded tabs from all makefiles since no longer neededCommit-type: housekeeping
Remove need for seperate lib/petsc/conf/test file by merging with rules fileCommit-type: maintainability
Remove empty preprocessor variables
Remove unneeded declarations of LOCDIR from all the makefilesCommit-type:documentation
Make PetscErrorCode a non-discardable enum
source code format changes due to .clang-format changes
docs: remove SUBMANSEC from example makefiles - and use only MANSEC (it tells what library the tests need)
Remove braces from one-liners w/o PetscCall()
clang-format: convert PETSc sources to comply with clang-format
Add PetscFunctionBeginUser to all PETSc C/C++ examplesNow the stack frames will contain the main program and the correct line numbers in themgit ls-files | egrep "(tutorials|tests)" | xargs sed -
Add PetscFunctionBeginUser to all PETSc C/C++ examplesNow the stack frames will contain the main program and the correct line numbers in themgit ls-files | egrep "(tutorials|tests)" | xargs sed -i "s?\(PetscCall(PetscInitialize(&argc\)?PetscFunctionBeginUser;\n \1?g"Commit-type: error-checking, testing-fix/spend 15m
show more ...
Get values of makefile SOURCE etc from the file system instead of makefilesUse SUBMANSEC from include files for manual sections instead of the makefileUnfortunately this has to be one large commi
Get values of makefile SOURCE etc from the file system instead of makefilesUse SUBMANSEC from include files for manual sections instead of the makefileUnfortunately this has to be one large commit since the changes all have to be done at onceCommit-type: docs/spend 10m
remove garbage from makefilesIncluding * unused FLAGS variables * All: lib that did not work * stray blank lines etcCommit-type: housekeeping/spend 1h
Enable PETSC_ATTRIBUTE_FORMAT()
Docs: remove "Concepts:" and related comments in /*T .. T*/ blocksRemove all \*T ... comment blocks with e.g. cd src && find . -type f -exec sed -i '/^[! ] *\/\*T$/,/^[! ]*T\*\/$/d' {} \;Clea
Docs: remove "Concepts:" and related comments in /*T .. T*/ blocksRemove all \*T ... comment blocks with e.g. cd src && find . -type f -exec sed -i '/^[! ] *\/\*T$/,/^[! ]*T\*\/$/d' {} \;Clean up resulting double blank lines with e.g. cd src && find . type f \( -name "*.c" -o -name "*.cxx" -o -name "*.F" -o -name "*.F90" \) -exec sh -c "cat -s {} > tmp && mv tmp {}" \;Manually revert those changes from the vendored code (src/sys/yaml)Manually restore a few comments from these blocks.Manually remove "Concepts:" and "Processors:" comments from fileswhich have these outside of "\*T" blocks automatically deleted above.
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX
The great renaming:- CHKERRQ() -> PetscCall()- CHKERRV() -> PetscCallVoid()- CHKERRMPI() -> PetscCallMPI()- CHKERRABORT() -> PetscCallAbort()- CHKERRCONTINUE() -> PetscCallContinue()- CHKERRXX() -> PetscCallThrow()- CHKERRCXX() -> PetscCallCXX()- CHKERRCUDA() -> PetscCallCUDA()- CHKERRCUBLAS() -> PetscCallCUBLAS()- CHKERRCUSPARSE() -> PetscCallCUSPARSE()- CHKERRCUSOLVER() -> PetscCallCUSOLVER()- CHKERRCUFFT() -> PetscCallCUFFT()- CHKERRCURAND() -> PetscCallCURAND()- CHKERRHIP() -> PetscCallHIP()- CHKERRHIPBLAS() -> PetscCallHIPBLAS()- CHKERRHIPSOLVER() -> PetscCallHIPSOLVER()- CHKERRQ_CEED() -> PetscCallCEED()- CHKERR_FORTRAN_VOID_FUNCTION() -> PetscCallFortranVoidFunction()- CHKERRMKL() -> PetscCallMKL()- CHKERRMMG() -> PetscCallMMG()- CHKERRMMG_NONSTANDARD() -> PetscCallMMG_NONSTANDARD()- CHKERRCGNS() -> PetscCallCGNS()- CHKERRPTSCOTCH() -> PetscCallPTSCOTCH()- CHKERRSTR() -> PetscCallSTR()- CHKERRTC() -> PetscCallTC()
PetscInitialize() and PetscFinalize() wrapped:- ierr = PetscInitialize();if (ierr) return ierr;+ CHKERRQ(PetscInitialize());- ierr = PetscFinalize();- return ierr;+ CHKERRQ(PetscFinalize());+
PetscInitialize() and PetscFinalize() wrapped:- ierr = PetscInitialize();if (ierr) return ierr;+ CHKERRQ(PetscInitialize());- ierr = PetscFinalize();- return ierr;+ CHKERRQ(PetscFinalize());+ return 0;
chkerr and friends wrapped
TAO: add TAOPYTHON classdeprecate Tao basic API to match SNES and TS paradigmsTaoSetFromOptions: call TaoLineSearchSetFromOptions
Fix missing ierr =, removed incorrect CHKERRQ()Commit-type: error-checking, style-fix\spend 45m
12