checkbadSource: enforce proper style in makefiles
Run fprettify
use integer and real kinds from ISO_C_bindingThe kinds in this module are guaranteed to be compatible with thecorresponding C types.Requires to include the ISO_C_binding module in interfaces and
use integer and real kinds from ISO_C_bindingThe kinds in this module are guaranteed to be compatible with thecorresponding C types.Requires to include the ISO_C_binding module in interfaces and strayfunctions
show more ...
use array notation (=vectorize)
give intent = (in,out,inout) and mark as pure
regular do without line numberconsistent indentation (2 spaces)
Fortran: remove unneeded return
LIBBASE is no longer used in make so remove it
Rename rules.doc and rules.utils because GitLab treats the former as a MS Word document.Thanks-to: Jed Brown
Remove first and last empty lines
Convert all header guards to pragma once
non-test and tutorial makefiles only need rules.doc not the full rulesCommit-type: documentation
Only makefiles in the test and tutorial directories need lib/petsc/conf/testCommit-type: housekeeping
Remove now unneeded SOURCE* variables from makefilesCommit-type: configure, housekeeping
Remove empty preprocessor variables
Remove unneeded declarations of LOCDIR from all the makefilesCommit-type:documentation
Change the remaining if !defined() header guards that were missed during The Great Formatting 2 to ifndef
source code format changes due to .clang-format changes
makefile: fix typo - petsckdir.mk -> petscdir.mk
clang-format: convert PETSc sources to comply with clang-format
Add -include */petscdir.mk to makefile that lacked itfor i in `git ls-files | grep makefile | xargs grep -L petscdir.mk`; do echo $i ; str=`echo $i |sed -e 's?[-a-zA-Z0-9]*/?../?g' -e 's?makef
Add -include */petscdir.mk to makefile that lacked itfor i in `git ls-files | grep makefile | xargs grep -L petscdir.mk`; do echo $i ; str=`echo $i |sed -e 's?[-a-zA-Z0-9]*/?../?g' -e 's?makefile?petsckdir.mk?g'` ; cp $i tmp echo "-include $str" > $i cat tmp >> $idoneCommit-type: makefile, housekeeping/spend 15m
remove garbage from makefilesIncluding * unused FLAGS variables * All: lib that did not work * stray blank lines etcCommit-type: housekeeping/spend 1h
Remove all double blank lines from sourceCommit-type: petsc-style/2h
rename all petsc .F sources to .F90[this prevents issue like processing include files like mpif.h as f77 fixed source that can cause grief with -i8 build with mpich]
Remove the needed def extension from Fortran include filesTime: .3 hoursThanks-to: Satish Balay <balay@mcs.anl.gov>
12